Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes and additionalRequirements support #4

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Bug fixes and additionalRequirements support #4

merged 4 commits into from
Apr 15, 2024

Conversation

nadavbuc
Copy link
Contributor

@nadavbuc nadavbuc commented Apr 15, 2024 •
edited
Loading

Changes

  • Make HeadRoom PodAntiAffinity optional for workloads
  • Remove exclusion of CPU Manufacturers
  • Add optional additional requirements to support any uncovered use-case
  • Make sure full coverage

Checklist

  • README is updated with new configuration values (if applicable)
  • Changes were tested and verified locally
  • Changes are covered by Unit Tests
  • Version is bumped in Chart.yaml

Fixes

  • Readme Fixes
  • Bug Fixes on additionalTags and amiSelector which added nulls
  • No creation of nodeClass if specific nodeClassRef is specified

@nadavbuc nadavbuc changed the title Improvements Bug fixes and additionalRequirements support Apr 15, 2024
@nadavbuc nadavbuc merged commit 4ae9e24 into master Apr 15, 2024
4 checks passed
@nadavbuc nadavbuc deleted the fix_nodeclass_and_readme branch April 15, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpodobiedov nickpodobiedov nickpodobiedov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nadavbuc @nickpodobiedov